linux-kernel - Re: [PATCH v2 1/1] serial: 8250_dw: Fix get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54FDEBB6.1060400@broadcom.com>
Date:	Mon, 9 Mar 2015 11:51:34 -0700
From:	Jonathan Richardson <jonathar@...adcom.com>
To:	Dmitry Torokhov <dtor@...omium.org>
CC:	Anatol Pomazau <anatol@...gle.com>,
	Scott Branden <sbranden@...adcom.com>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	"Mark Rutland" <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	"Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
	Jiri Slaby <jslaby@...e.cz>, <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	<linux-serial@...r.kernel.org>, Arnd Bergmann <arnd@...db.de>,
	Desmond Liu <desmondl@...adcom.com>
Subject: Re: [PATCH v2 1/1] serial: 8250_dw: Fix get_mctrl behaviour

On 15-03-09 11:40 AM, Dmitry Torokhov wrote:
> On Thu, Feb 26, 2015 at 4:35 PM, Jonathan Richardson
> <jonathar@...adcom.com> wrote:
>> @@ -334,6 +342,30 @@ static int dw8250_probe_of(struct uart_port *p,
>>         if (id >= 0)
>>                 p->line = id;
>>
>> +       if (of_property_read_bool(np, "dcd-override")) {
>> +               /* Always report DCD as active */
>> +               data->msr_mask_on |= UART_MSR_DCD;
>> +               data->msr_mask_off |= UART_MSR_DDCD;
>> +       }
>> +
>> +       if (of_property_read_bool(np, "dsr-override")) {
>> +               /* Always report DSR as active */
>> +               data->msr_mask_on |= UART_MSR_DSR;
>> +               data->msr_mask_off |= UART_MSR_DDSR;
>> +       }
>> +
>> +       if (of_property_read_bool(np, "cts-override")) {
>> +               /* Always report DSR as active */
>> +               data->msr_mask_on |= UART_MSR_DSR;
>> +               data->msr_mask_off |= UART_MSR_DDSR;
>> +       }
>> +
>> +       if (of_property_read_bool(np, "ri-override")) {
>> +               /* Always report Ring indicator as inactive */
>> +               data->msr_mask_off |= UART_MSR_RI;
>> +               data->msr_mask_off |= UART_MSR_TERI;
> 
> This looks like a typo. Should the 1st line be data->msr_mask_on by any chance?

I think the code is correct. The signals other than ri need to be
reported as active (masked on) if specified, but ri needs to be inactive
(masked off) unlike the other 3. This is stated in the kernel docs
mentioned in the commit. ri behaves differently than the others.

> 
> Thanks,
> Dmitry
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/