linux-kernel - Re: [PATCH v4 2/2] cgroups: add a pids subsystem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150309033946.GG13283@htj.duckdns.org>
Date:	Sun, 8 Mar 2015 23:39:46 -0400
From:	Tejun Heo <tj@...nel.org>
To:	Aleksa Sarai <cyphar@...har.com>
Cc:	lizefan@...wei.com, mingo@...hat.com, peterz@...radead.org,
	richard@....at, fweisbec@...il.com, linux-kernel@...r.kernel.org,
	cgroups@...r.kernel.org
Subject: Re: [PATCH v4 2/2] cgroups: add a pids subsystem

On Sun, Mar 08, 2015 at 11:34:05PM -0400, Tejun Heo wrote:
> > +	for (p = pids; p; p = p->parent) {
> > +		long new;
> > +
> > +		new = atomic_long_add_return(num, &p->counter);
> > +
> > +		if (p->limit == PIDS_UNLIMITED)
> > +			continue;
> 
> Huh?  So, the counter stays out of sync if unlimited?  What happens
> when it gets set to something else later?

Oops, I misread the code, but why is PIDS_UNLIMITED a special case?
Just make it a number which always makes the condition true?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/