linux-kernel - Re: [PATCH baohua] ASoC: sirf: atlas7: atlas7_iacc_dai

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150310034139.GA17221@wfg-t540p.sh.intel.com>
Date:	Tue, 10 Mar 2015 11:41:39 +0800
From:	Fengguang Wu <fengguang.wu@...el.com>
To:	Mark Brown <broonie@...nel.org>
Cc:	Rongjun Ying <rongjun.ying@....com>, kbuild-all@...org,
	Barry Song <Barry.Song@....com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>,
	alsa-devel@...a-project.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH baohua] ASoC: sirf: atlas7: atlas7_iacc_dai_ops can be
 static

On Thu, Feb 05, 2015 at 05:11:59PM +0000, Mark Brown wrote:
> On Fri, Feb 06, 2015 at 01:03:52AM +0800, kbuild test robot wrote:
> > sound/soc/sirf/atlas7-iacc.c:168:24: sparse: symbol 'atlas7_iacc_dai_ops' was not declared. Should it be static?
> 
> This file isn't in an upstream tree, should this patch have been sent
> upstream (I suspect non-upstream trees may need a bit of filtering in
> the scripts)?

Good point! I just added some tests trying to avoid this, which should
be much better, but nevertheless not complete enough to cover all cases.
Please help point out inadequate cases when you come across them in future!

Thanks,
Fengguang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/