linux-kernel - RE: [RFC 1/4] power_supply: Introduce charging object table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20ADAB092842284E95860F279283C5642EECB1D7@BGSMSX104.gar.corp.intel.com>
Date:	Tue, 10 Mar 2015 05:16:53 +0000
From:	"Tc, Jenny" <jenny.tc@...el.com>
To:	'Sebastian Reichel' <sre@...nel.org>
CC:	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Anton Vorontsov" <anton.vorontsov@...aro.org>,
	David Woodhouse <dwmw2@...radead.org>,
	"jonghwa3.lee@...sung.com" <jonghwa3.lee@...sung.com>,
	"myungjoo.ham@...il.com" <myungjoo.ham@...il.com>,
	"Pallala, Ramakrishna" <ramakrishna.pallala@...el.com>
Subject: RE: [RFC 1/4] power_supply: Introduce charging object table

> 
> On Mon, Mar 09, 2015 at 12:26:21PM +0000, Tc, Jenny wrote:
> > > > +	char name[PSY_MAX_BAT_NAME_LEN];
> > >
> > > char *name;
> > >
> > > No need for arbitrary length limitation.
> >
> > The length limitation is introduced to form a packed structure so that
> > the data can be read directly from memory without parsing.
> 
> This reason is ok for a device driver, but not for a kernel
> subsystem.

Agree, will fix this. Same for psy_temp_mon_table temp_mon_table

-Jenny
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/