linux-kernel

Open Source and information security mailing list archives

Message-ID: <20150310065146.GL10964@mwanda>
Date:	Tue, 10 Mar 2015 09:51:46 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	markh@...pro.net
Cc:	Matteo Semenzato <mattew8898@...il.com>,
	gregkh@...uxfoundation.org, lidza.louina@...il.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: dgnc: fix bitmask

On Mon, Mar 09, 2015 at 09:14:38PM +0100, Matteo Semenzato wrote:
> From: Matteo Semenzato <mattew8898@...il.com>
> 
> The bitmask should be used on msignals since the signals variable is not
> used anywhere in the function.
> 

You're probably right.  I would really like to get Mark's Ack on this
though becuase it's sort of a guess and not tested.

regards,
dan carpenter

> Signed-off-by: Matteo Semenzato <mattew8898@...il.com>
> ---
>  drivers/staging/dgnc/dgnc_cls.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c
> index bedc522..29c6316 100644
> --- a/drivers/staging/dgnc/dgnc_cls.c
> +++ b/drivers/staging/dgnc/dgnc_cls.c
> @@ -1137,7 +1137,7 @@ static void cls_parse_modem(struct channel_t *ch, unsigned char signals)
>  	 * Scrub off lower bits. They signify delta's, which I don't
>  	 * care about
>  	 */
> -	signals &= 0xf0;
> +	msignals &= 0xf0;
>  
>  	spin_lock_irqsave(&ch->ch_lock, flags);
>  	if (msignals & UART_MSR_DCD)
> -- 
> 2.3.1
> 
> _______________________________________________
> devel mailing list
> devel@...uxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives