[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <1425975056.2440.24.camel@mm-sol.com>
Date: Tue, 10 Mar 2015 10:10:56 +0200
From: "Ivan T. Ivanov" <iivanov@...sol.com>
To: Mark Brown <broonie@...nel.org>
Cc: linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH 2/2] spi: qup: Request CS GPIO's during probe
On Mon, 2015-03-09 at 18:28 +0000, Mark Brown wrote:
> On Mon, Mar 09, 2015 at 10:23:35AM +0200, Ivan T. Ivanov wrote:
> > Hi,
>
> Don't reply off list unless there's a good reason...
Sorry, it was not intentional. Wrong button.
>
> > > Any new GPIO users should really be using the gpiod API, however this is
> > > duplicating core functionality so as Stephen says why are we doing this?
>
> > About the API usage, point taken. GPIO requesting part is more important
> > in this case. pinctrl core did not request pins and wrong DT configuration
> > could lead to surprises without any warnings or errors.
>
> That doesn't answer my concern at all.
I am not sure that I am following you.
I can not use spi_master::cs_gpios, which is populated by
of_spi_register_master(), because spi_register_master()
populate SPI devices and they could issue setup method.
Requesting GPIO's in core framework is also not a easy
option because of arguments here[1].
Probably I am still missing something.
Regards,
Ivan
[1] https://lkml.org/lkml/2014/5/24/75
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists