linux-kernel - Re: [DRBD-user] [patch 1/2] block, drbd: fix drbd_req

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150310103838.GB3961@soda.linbit>
Date:	Tue, 10 Mar 2015 11:38:38 +0100
From:	Lars Ellenberg <lars.ellenberg@...bit.com>
To:	David Rientjes <rientjes@...gle.com>
Cc:	Jens Axboe <axboe@...com>, drbd-dev@...ts.linbit.com,
	linux-kernel@...r.kernel.org
Subject: Re: [DRBD-user] [patch 1/2] block, drbd: fix drbd_req_new()
 initialization

On Sat, Mar 07, 2015 at 04:24:02PM -0800, David Rientjes wrote:
> mempool_alloc() does not support __GFP_ZERO since elements may come from
> memory that has already been released by mempool_free().
> 
> Remove __GFP_ZERO from mempool_alloc() in drbd_req_new() and properly
> initialize it to 0.

We used to have the explicit memset there,
but then changed that, because

I was under the impression that since
2007-07-17 d07dbea, Slab allocators: support __GFP_ZERO in all allocators
it was supported?

	Lars Ellenberg

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/