linux-kernel - Re: [PATCH] staging: sm750fb: Cleanup the type of mmio750

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAA5enKZMZDVzEjZG1mccn089MEN3AvSQc+TECc6vMZBKB06TRA@mail.gmail.com>
Date:	Tue, 10 Mar 2015 12:47:44 +0000
From:	Lorenzo Stoakes <lstoakes@...il.com>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:	Dan Carpenter <dan.carpenter@...cle.com>,
	teddy.wang@...iconmotion.com, Greg KH <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org, linux-fbdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: sm750fb: Cleanup the type of mmio750

On 10 March 2015 at 12:36, Sudip Mukherjee <sudipm.mukherjee@...il.com> wrote:
> but it is introducing two new build warnings:
>
> drivers/staging/sm750fb/sm750_hw.c: In function ‘hw_sm750_map’:
> drivers/staging/sm750fb/sm750_hw.c:67:2: warning: passing argument 1 of ‘ddk750_set_mmio’ discards ‘volatile’ qualifier from pointer target type [enabled by default]
> In file included from drivers/staging/sm750fb/ddk750_mode.h:4:0,
>                     from drivers/staging/sm750fb/ddk750.h:15,
>                     from drivers/staging/sm750fb/sm750_hw.c:24:
>
> and
>
> drivers/staging/sm750fb/ddk750_chip.h:77:6: note: expected ‘void *’ but argument is of type ‘volatile unsigned char *’
>
> care to make another patch to solve these two new warnings, and send this patch and the new one in a series and while sending mark the version number in the subject.

I think the second warning is simply additional information attached
to the 1st to give context?

I noticed this issue but felt changing the type of this field would
sit outside the purview of this patch as then I'm not only changing
the type of mmio750 and code that *directly* interacts with this
variable, but also code that indirectly interacts with it, so I felt
that should perhaps be a separate patch.

I'd love to additionally provide some further patches to help out with
issues here too, incidentally! I will try to prepare some further
patches tonight in this vein.

-- 
Lorenzo Stoakes
https:/ljs.io
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/