linux-kernel - Re: [RFC] lib/vsprintf.c: Even faster decimal conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87vbi96mcr.fsf@rasmusvillemoes.dk>
Date:	Tue, 10 Mar 2015 13:57:56 +0100
From:	Rasmus Villemoes <linux@...musvillemoes.dk>
To:	Tejun Heo <tj@...nel.org>
Cc:	Joe Perches <joe@...ches.com>, linux-kernel@...r.kernel.org,
	"Peter Zijlstra \(Intel\)" <peterz@...radead.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [RFC] lib/vsprintf.c: Even faster decimal conversion

On Tue, Mar 10 2015, Tejun Heo <tj@...nel.org> wrote:

> Hello,
>
> On Tue, Mar 10, 2015 at 11:47:47AM +0100, Rasmus Villemoes wrote:
>> I can't explain why num_to_str apparently becomes slightly slower (the
>> patch essentially didn't touch it), but the put_dec_ helpers in any case
>> make up for that.
>
> Unrelated code changes affecting performance in seemingly random way
> isn't too uncommon.  A lot of it arises from cacheline behaviors.  The
> effect is sometimes surprisingly big.
>
> Generally looks pretty good to me.

Thanks.

> Andrew, can you please pick this patch up?

No, please give me a day or two to post a new version (I purposely wrote
not-yet-signed-off-by because I want to clean up both the patch and the
commit message - I just wanted to get the code out there early in the
release cycle).

Rasmus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/