| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 10 Mar 2015 13:22:03 +0000 From: Lorenzo Stoakes <lstoakes@...il.com> To: Dan Carpenter <dan.carpenter@...cle.com> Cc: Sudip Mukherjee <sudipm.mukherjee@...il.com>, teddy.wang@...iconmotion.com, Greg KH <gregkh@...uxfoundation.org>, devel@...verdev.osuosl.org, linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] staging: sm750fb: Cleanup the type of mmio750 On 10 March 2015 at 13:06, Dan Carpenter <dan.carpenter@...cle.com> wrote: > You should have said that in the patch description or under the --- > cut off. But anyway, it's not ok. And we'll need to redo this patch. > Breaking up patches into logical changes is sort of tricky because > everything touches everything else so the patch gets larger and larger. > Major apologies, I am still getting used to kernel development! I'll be careful to not make such assumptions in future when it comes to warnings/errors. [snip] > But maybe it's only one line larger than the patch you just send? In > that case just fold it in and don't do the temporary casting. > > The next patch after that could get rid of all the ramaining "volatile" > keywords. It seems that we can in fact fix this problem with a single additional change, I will submit a v2 shortly. Best, -- Lorenzo Stoakes https:/ljs.io -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists