linux-kernel - Re: [PATCH] efi: Disable interrupts around EFI calls, not in the epilog/prolog calls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150310133618.GB17573@codeblueprint.co.uk>
Date:	Tue, 10 Mar 2015 13:36:18 +0000
From:	Matt Fleming <matt@...eblueprint.co.uk>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	Tapasweni Pathak <tapaswenipathak@...il.com>,
	matt.fleming@...el.com, tglx@...utronix.de, mingo@...hat.com,
	hpa@...or.com, x86@...nel.org, linux-efi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] efi: Disable interrupts around EFI calls, not in the
 epilog/prolog calls

On Tue, 03 Mar, at 07:34:33AM, Ingo Molnar wrote:
> 
> So why are interrupts disabled around page table operations to begin 
> with? It's not like any of this can execute on two CPUs at once, nor 
> can this be executed from interrupt context.
> 
> So, shouldn't we only protect the EFI calls themselves? If we did that 
> we could save the efi_flags global variable ugliness as well.
> 
> I.e. something like the attached patch. (not tested and all that)

Looks good to me Ingo. I'll run it through the test farm. Thanks!

-- 
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/