linux-kernel - Re: [PATCH 1/4] perf, tools: Output running time and run/enabled ratio in CSV mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150310153704.GH31334@tassilo.jf.intel.com>
Date:	Tue, 10 Mar 2015 08:37:04 -0700
From:	Andi Kleen <ak@...ux.intel.com>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	Andi Kleen <andi@...stfloor.org>, acme@...nel.org,
	jolsa@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] perf, tools: Output running time and run/enabled
 ratio in CSV mode

> Why not handle both cases here?
> 
> static void print_running(u64 run, u64 ena)
> {
> 	if (csv_output)
> 		fprintf(output, ...);
> 	else if (run != ena)
> 		fprintf(output, ...);
> }

print_running has 6 callers. run != ena is only needed
for two of them. So I don't think it makes sense to do.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/