linux-kernel - Re: [PATCH 00/56] staging: comedi: introduce comedi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1426004716.18060.10.camel@perches.com>
Date:	Tue, 10 Mar 2015 09:25:16 -0700
From:	Joe Perches <joe@...ches.com>
To:	Ian Abbott <abbotti@....co.uk>
Cc:	driverdev-devel@...uxdriverproject.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	H Hartley Sweeten <hartleys@...ionengravers.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 00/56] staging: comedi: introduce comedi_pci.h header

On Tue, 2015-03-10 at 16:10 +0000, Ian Abbott wrote:
> "comedidev.h" includes PCI-specific stuff that gets included by all
> comedi drivers including non-PCI ones.  Separate it out into its own
> header "comedi_pci.h".  Make the new header include <linux/pci.h> and
> "comedidev.h" so that comedi PCI drivers do not need to include them
> explicitly.

Isn't the kernel progressing to avoid indirect includes?

Perhaps it'd be nicer to move generic comedi .h files into
a more common location and change the include path so that
the include statements don't have to be relative?

Maybe add an include/comedi/ directory?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/