linux-kernel - Re: [PATCH v2 1/2] x86_64,signal: Fix SS handling for signals delivered to 64-bit programs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 10 Mar 2015 10:35:20 -0700
From:	Andy Lutomirski <luto@...capital.net>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	Ingo Molnar <mingo@...nel.org>, Andi Kleen <andi@...stfloor.org>,
	"H. Peter Anvin" <hpa@...or.com>,
	Al Viro <viro@...iv.linux.org.uk>, X86 ML <x86@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Borislav Petkov <bp@...en8.de>
Subject: Re: [PATCH v2 1/2] x86_64,signal: Fix SS handling for signals
 delivered to 64-bit programs

On Tue, Mar 10, 2015 at 9:42 AM, Oleg Nesterov <oleg@...hat.com> wrote:
> Well, the patch looks "obviously fine" to me, but this is all I can say.
>
> I mean, I simply can't understand this __pad0/ifdef(CONFIG_X86_32), it
> looks as if ->ss was specially excluded for unknown reason from the very
> beginning.

I assume it was confusion in the very early days of x86_64.  Andi?

>
> On 03/10, Andy Lutomirski wrote:
>>
>> > --- a/arch/x86/include/uapi/asm/sigcontext.h
>> > +++ b/arch/x86/include/uapi/asm/sigcontext.h
>> > @@ -179,7 +179,7 @@ struct sigcontext {
>> >         __u16 cs;
>> >         __u16 gs;
>> >         __u16 fs;
>> > -       __u16 __pad0;
>> > +       __u16 ss;
>
> I do not know the rules for include/uapi/ ...
>
> OK, nobody should ever use __pad0, so probably it is safe to rename it.
> OTOH, an application can (say) try to print all members for debugging
> purposes, it won't compile after this change.

Yeah, I don't really know what the rules are.

--Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/