linux-kernel - Re: [patch v3] mm, hugetlb: abort __get_user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1426015564.2055.2.camel@stgolabs.net>
Date:	Tue, 10 Mar 2015 12:26:04 -0700
From:	Davidlohr Bueso <dave@...olabs.net>
To:	David Rientjes <rientjes@...gle.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Greg Thelen <gthelen@...gle.com>,
	Naoya Horiguchi <n-horiguchi@...jp.nec.com>,
	"Kirill A. Shutemov" <kirill@...temov.name>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [patch v3] mm, hugetlb: abort __get_user_pages if current has
 been oom killed

On Mon, 2015-03-09 at 13:07 -0700, David Rientjes wrote:
> If __get_user_pages() is faulting a significant number of hugetlb pages,
> usually as the result of mmap(MAP_LOCKED), it can potentially allocate a
> very large amount of memory.
> 
> If the process has been oom killed, this will cause a lot of memory to
> potentially deplete memory reserves.
> 
> In the same way that commit 4779280d1ea4 ("mm: make get_user_pages() 
> interruptible") aborted for pending SIGKILLs when faulting non-hugetlb
> memory, based on the premise of commit 462e00cc7151 ("oom: stop
> allocating user memory if TIF_MEMDIE is set"), hugetlb page faults now
> terminate when the process has been oom killed.
> 
> Cc: Greg Thelen <gthelen@...gle.com>
> Cc: Naoya Horiguchi <n-horiguchi@...jp.nec.com>
> Cc: Davidlohr Bueso <dave@...olabs.net>
> Acked-by: "Kirill A. Shutemov" <kirill@...temov.name>
> Signed-off-by: David Rientjes <rientjes@...gle.com>

Makes sense.

Acked-by: Davidlohr Bueso <dave@...olabs.net>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/