linux-kernel - Re: [PATCH] NVMe: Fix error handling of class

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150310194629.GQ2780@wil.cx>
Date:	Tue, 10 Mar 2015 15:46:29 -0400
From:	Matthew Wilcox <willy@....cx>
To:	J Freyensee <james_p_freyensee@...ux.intel.com>
Cc:	Alexey Khoroshilov <khoroshilov@...ras.ru>,
	Matthew Wilcox <willy@...ux.intel.com>,
	Keith Busch <keith.busch@...el.com>,
	ldv-project@...uxtesting.org, linux-nvme@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] NVMe: Fix error handling of class_create("nvme")

On Tue, Mar 10, 2015 at 12:18:22PM -0700, J Freyensee wrote:
> Looking at IS_ERR(), it uses IS_ERR_VALUE() which uses unlikely(), which
> from what I understand is a compiler hint that means "this error is
> unlikely to happen".
> 
> Well, is this error unlikely to happen?  Looks like the error could be

Yes.  All errors are, by definition, unlikely to happen.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/