linux-kernel - Re: [PATCH] udc: gadget: atmel_usba_udc: depend on COMMON_CLK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150310205312.GD18456@saruman.tx.rr.com>
Date:	Tue, 10 Mar 2015 15:53:12 -0500
From:	Felipe Balbi <balbi@...com>
To:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
CC:	Boris Brezillon <boris.brezillon@...e-electrons.com>,
	Felipe Balbi <balbi@...com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	Nicolas Ferre <nicolas.ferre@...el.com>
Subject: Re: [PATCH] udc: gadget: atmel_usba_udc: depend on COMMON_CLK_AT91

On Tue, Mar 03, 2015 at 10:41:38AM +0100, Alexandre Belloni wrote:
> On 03/03/2015 at 09:26:20 +0100, Boris Brezillon wrote :
> > >  config USB_ATMEL_USBA
> > >  	tristate "Atmel USBA"
> > > -	depends on AVR32 || ARCH_AT91
> > > +	depends on AVR32 || ARCH_AT91 && COMMON_CLK_AT91
> > 
> > I guess you should add parenthesis to make it clearer ?
> > 
> > 	depends on AVR32 || (ARCH_AT91 && COMMON_CLK_AT91)
> > 
> > And I wonder why you need that. I though this option was selected by all
> > at91 platforms ?
> > 
> 
> That is currently the case but maybe, one day, one of the AT91 platform
> will not use the same clock driver.

then, maybe, one day, you send this patch.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)