linux-kernel - Re: gadgetfs broken since 7f7f25e8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150310210754.GB25666@saruman.tx.rr.com>
Date:	Tue, 10 Mar 2015 16:07:54 -0500
From:	Felipe Balbi <balbi@...com>
To:	Alan Stern <stern@...land.harvard.edu>
CC:	Al Viro <viro@...IV.linux.org.uk>,
	Alexander Holler <holler@...oftware.de>,
	Richard Weinberger <richard.weinberger@...il.com>,
	USB list <linux-usb@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>, Felipe Balbi <balbi@...com>
Subject: Re: gadgetfs broken since 7f7f25e8

On Sun, Mar 08, 2015 at 02:35:25PM -0400, Alan Stern wrote:
> On Sun, 8 Mar 2015, Al Viro wrote:
> 
> > On Sat, Mar 07, 2015 at 04:08:49PM -0500, Alan Stern wrote:
> > > On Sat, 7 Mar 2015, Alexander Holler wrote:
> > > 
> > > > Am 07.03.2015 um 12:23 schrieb Alexander Holler:
> > > > > Am 04.03.2015 um 16:31 schrieb Alan Stern:
> > > > > 
> > > > >> check to see what those values actually were.  It's easy enough to fix
> > > > >> up, though; revised patch below.
> > > > > 
> > > > > Thanks, in contrast to the patch from Al Viro that one applies.
> > > > 
> > > > And as I've just tested it, it isn't complete. ep_config_operations will
> > > > be switched to ep_io_operations and suffers under the same problem of
> > > > not having initially (aio_)read/(aio_)write since commit  7f7f25e8 (3.16).
> > > 
> > > Of course.  I stated in the email accompanying the original version of
> > > this patch that it contained some corrections that Al's patch left out.  
> > > You have to use the two of them together to fix all the issues.
> > 
> > FWIW, I've pushed those two fixes in vfs.git#gadget; could I have your
> > s-o-b on the ep0 part?  See 2b13438 in vfs.git...
> 
> Certainly.
> 
> Signed-off-by: Alan Stern <stern@...land.harvard.edu>

Just to make sure people know I'm okay with you taking the patch:

Acked-by: Felipe Balbi <balbi@...com>

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)