linux-kernel - Re: [PATCH] udc: gadget: atmel_usba_udc: depend on COMMON_CLK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 10 Mar 2015 16:23:53 -0500
From:	Felipe Balbi <balbi@...com>
To:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
CC:	Felipe Balbi <balbi@...com>,
	Boris Brezillon <boris.brezillon@...e-electrons.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	Nicolas Ferre <nicolas.ferre@...el.com>
Subject: Re: [PATCH] udc: gadget: atmel_usba_udc: depend on COMMON_CLK_AT91

On Tue, Mar 10, 2015 at 10:21:22PM +0100, Alexandre Belloni wrote:
> On 10/03/2015 at 15:53:12 -0500, Felipe Balbi wrote :
> > On Tue, Mar 03, 2015 at 10:41:38AM +0100, Alexandre Belloni wrote:
> > > On 03/03/2015 at 09:26:20 +0100, Boris Brezillon wrote :
> > > > >  config USB_ATMEL_USBA
> > > > >  	tristate "Atmel USBA"
> > > > > -	depends on AVR32 || ARCH_AT91
> > > > > +	depends on AVR32 || ARCH_AT91 && COMMON_CLK_AT91
> > > > 
> > > > I guess you should add parenthesis to make it clearer ?
> > > > 
> > > > 	depends on AVR32 || (ARCH_AT91 && COMMON_CLK_AT91)
> > > > 
> > > > And I wonder why you need that. I though this option was selected by all
> > > > at91 platforms ?
> > > > 
> > > 
> > > That is currently the case but maybe, one day, one of the AT91 platform
> > > will not use the same clock driver.
> > 
> > then, maybe, one day, you send this patch.
> 
> Yeah, let's drop it for now but I have the feeling that this will
> break (I actually broke it when switching at91 to multiplatform).

aha, that changes it. So you already have something which makes this
break ? Are you planning on sending that upstream any time soon ?

We could very well use that same series to merge this patch. Only when
it's needed ;-)

cheers

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)