linux-kernel - Re: [PATCH] staging: fbtft: Do not use binary constants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1426024241.18060.53.camel@perches.com>
Date:	Tue, 10 Mar 2015 14:50:41 -0700
From:	Joe Perches <joe@...ches.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>,
	Noralf Trønnes <noralf@...nnes.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: fbtft: Do not use binary constants

On Tue, 2015-03-10 at 22:34 +0100, Geert Uytterhoeven wrote:
> Gcc < 4.3 doesn't understand binary constants (0b*):

trivia:

> diff --git a/drivers/staging/fbtft/fb_hx8340bn.c b/drivers/staging/fbtft/fb_hx8340bn.c
[]
> @@ -156,10 +156,10 @@ static int set_var(struct fbtft_par *par)
>  static int set_gamma(struct fbtft_par *par, unsigned long *curves)
>  {
>  	unsigned long mask[] = {

static const

> -		0b1111, 0b1111, 0b11111, 0b1111, 0b1111, 0b1111, 0b11111,
> -		0b111, 0b111, 0b111, 0b111, 0b111, 0b111, 0b11, 0b11,
> -		0b1111, 0b1111, 0b11111, 0b1111, 0b1111, 0b1111, 0b11111,
> -		0b111, 0b111, 0b111, 0b111, 0b111, 0b111, 0b0, 0b0 };
> +		0x0f, 0x0f, 0x1f, 0x0f, 0x0f, 0x0f, 0x1f, 0x07, 0x07, 0x07,
> +		0x07, 0x07, 0x07, 0x03, 0x03, 0x0f, 0x0f, 0x1f, 0x0f, 0x0f,
> +		0x0f, 0x1f, 0x07, 0x07, 0x07, 0x07, 0x07, 0x07, 0x00, 0x00,
> +	};

[]

> diff --git a/drivers/staging/fbtft/fb_hx8347d.c b/drivers/staging/fbtft/fb_hx8347d.c
[]
> @@ -115,10 +115,9 @@ static void set_addr_win(struct fbtft_par *par, int xs, int ys, int xe, int ye)
>  static int set_gamma(struct fbtft_par *par, unsigned long *curves)
>  {
>  	unsigned long mask[] = {

etc...

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/