linux-kernel - Re: [RFC 1/6] drm: Add top level Kconfig option for DRM fbdev emulation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54FFCB36.1050904@codeaurora.org>
Date:	Wed, 11 Mar 2015 10:27:26 +0530
From:	Archit Taneja <architt@...eaurora.org>
To:	Jani Nikula <jani.nikula@...ux.intel.com>, robdclark@...il.com,
	airlied@...ux.ie, treding@...dia.com, p.zabel@...gutronix.de,
	benjamin.gaignard@...aro.org, dri-devel@...ts.freedesktop.org,
	linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
	daniel@...ll.ch
Subject: Re: [RFC 1/6] drm: Add top level Kconfig option for DRM fbdev emulation



On 03/10/2015 09:03 PM, Jani Nikula wrote:
> On Tue, 10 Mar 2015, Archit Taneja <architt@...eaurora.org> wrote:
>> On 03/10/2015 03:35 PM, Daniel Vetter wrote:
>>> On Tue, Mar 10, 2015 at 03:22:49PM +0530, Archit Taneja wrote:
>>>>
>>>>
>>>> On 03/10/2015 03:17 PM, Daniel Vetter wrote:
>>>>> On Tue, Mar 10, 2015 at 03:11:28PM +0530, Archit Taneja wrote:
>>>> DRM_KMS_FB_HELPER selects that for us, right?
>>>
>>> Hm right I've missed that. Reminds me that you need one more patch at the
>>> end to remove all the various select DRM_KMS_FB_HELPER from all drm
>>> drivers. Otherwise this knob here won't work by default if you e.g. select
>>> radeon. In general we can't mix explicit options with menu entries with a
>>> select.
>>
>> I was trying that out. Removing DRM_KMS_FB_HELPER and having
>> DRM_FBDEV_EMULATION disabled breaks drivers which use FB stuff
>> internally in their respective xyz_fbdev.c files.
>>
>> Are you saying that we should remove DRM_KMS_FB_HELPER for such drivers
>> and replace them with 'select DRM_FBDEV_EMULATION'?
>
> Slightly tangential: As a rule of thumb, you should not "select"
> anything that is visible in menuconfig or has dependencies [1]. This
> will break the build eventually, and attempts to fix it are troublesome
> [2].

Thanks, I'll keep this in mind!

Archit

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/