linux-kernel - Re: [PATCH] staging: rtl8192e: rtllib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54FFEF99.4030806@gmail.com>
Date:	Wed, 11 Mar 2015 08:32:41 +0100
From:	Mateusz Kulikowski <mateusz.kulikowski@...il.com>
To:	Joe Perches <joe@...ches.com>
CC:	gregkh@...uxfoundation.org, mdcasey@...bloom.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8192e: rtllib_wx: code style improvements

On 11.03.2015 00:01, Joe Perches wrote:
> On Tue, 2015-03-10 at 23:53 +0100, Mateusz Kulikowski wrote:
>> - Replaced printk() with netdev_*()
> 
> trivia:
> 
>> diff --git a/drivers/staging/rtl8192e/rtllib_wx.c b/drivers/staging/rtl8192e/rtllib_wx.c
> []
>> @@ -423,11 +421,8 @@ int rtllib_wx_set_encode(struct rtllib_device *ieee,
>>  					     NULL, (*crypt)->priv);
>>  		if (len == 0) {
>>  			/* Set a default key of all 0 */
>> -			printk(KERN_INFO "Setting key %d to all zero.\n",
>> -					   key);
>> -
>> -			RTLLIB_DEBUG_WX("Setting key %d to all zero.\n",
>> -					   key);
>> +			netdev_info(dev, "Setting key %d to all zero.\n", key);
>> +			RTLLIB_DEBUG_WX("Setting key %d to all zero.\n", key);
> 
> This isn't something you've created but it
> seems more than a bit nonsensical to emit the
> same message at different logging levels.


Thanks for hint - I'll throw away duplicate messages for v2.

As for all standalone RTLLIB_DEBUG* entries (in whole driver) - 
I think it may be better to replace them with netdev_dbg, and use dynamic debug when needed. 


M.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/