linux-kernel - Re: [GIT PULL v2] of: Add of-graph helpers to loop over endpoints and find ports by id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1426063881.3101.33.camel@pengutronix.de>
Date:	Wed, 11 Mar 2015 09:51:21 +0100
From:	Philipp Zabel <p.zabel@...gutronix.de>
To:	Rob Herring <robherring2@...il.com>
Cc:	Russell King - ARM Linux <linux@....linux.org.uk>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Grant Likely <grant.likely@...aro.org>,
	Rob Herring <robh+dt@...nel.org>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Darren Etheridge <detheridge@...com>,
	"kernel@...gutronix.de" <kernel@...gutronix.de>,
	Mathieu Poirier <mathieu.poirier@...aro.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Benoit Parrot <bparrot@...com>,
	Andrzej Hajda <a.hajda@...sung.com>,
	Tomi Valkeinen <tomi.valkeinen@...com>,
	"linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	Guennadi Liakhovetski <g.liakhovetski@....de>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Mauro Carvalho Chehab <m.chehab@...sung.com>
Subject: Re: [GIT PULL v2] of: Add of-graph helpers to loop over endpoints
 and find ports by id

Hi Rob,

Am Dienstag, den 10.03.2015, 14:05 -0500 schrieb Rob Herring:
> I've only been copied on this latest pull request and a version from
> March of last year which Grant nak'ed. This series did not go to
> devicetree list either. I'll take a look at the series. 

My bad, I should have copied you, too. Thanks for having a look now.

The nak'ed series (https://lkml.org/lkml/2014/3/20/664) indeed already
included the "of: Add OF graph helper to get a specific port by id" and
"of: Add OF graph helpers to iterate over ports" patches, but Grant's
nak applied to the first patch, "of: Parse OF graph into graph
structure", which I then dropped.

> If there is an explanation of how Grant's nak was addressed that would
> speed up my review.

See above. The other two patches have been uncontroversial. The
of_graph_get_next_endpoint and for_each_endpoint_of_node patches
fix an in-kernel API that was too easy to use incorrectly, and
the of_graph_get_port_by_id patch I can't remember being
commented on at all.

> I'm not applying for v4.0 though.

If you decide to apply them, please consider merging the tag and giving
your ack for it to be merged into the other subsystem trees, too.

regards
Philipp

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/