linux-kernel - Re: [PATCH] crypto: AES-NI: fix memory usage in GCM decryption

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150311091016.GA7858@gondor.apana.org.au>
Date:	Wed, 11 Mar 2015 20:10:16 +1100
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Stephan Mueller <smueller@...onox.de>
Cc:	Tadeusz Struk <tadeusz.struk@...el.com>,
	linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: AES-NI: fix memory usage in GCM decryption

On Wed, Mar 11, 2015 at 09:01:02AM +0100, Stephan Mueller wrote:
>
> However, I think there is an error in the calculation of the AAD pointer 
> offset. That offset is currently calculated as:
> 
> assoc = (src + req->cryptlen + auth_tag_len);
> 
> But instead, it should be:
> 
> assoc = (src + req->cryptlen);
> 
> as our buffer is only cryptlen + assolen in size.
> 
> If you concur, I will write a patch and test it.

Yes that's the problem I was referring to.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/