linux-kernel - Re: [PATCH] virtio_rpmsg: set DRIVER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK=WgbYuv+7LLk0z-fM1q5zCxPTSUNW9piHcBK3mYLzR=j--HA@mail.gmail.com>
Date:	Wed, 11 Mar 2015 14:45:07 +0200
From:	Ohad Ben-Cohen <ohad@...ery.com>
To:	"Michael S. Tsirkin" <mst@...hat.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	virtualization <virtualization@...ts.linux-foundation.org>,
	Rusty Russell <rusty@...tcorp.com.au>,
	"kvm@...r.kernel.org" <kvm@...r.kernel.org>, qemu-devel@...gnu.org
Subject: Re: [PATCH] virtio_rpmsg: set DRIVER_OK before using device

On Mon, Mar 9, 2015 at 10:41 AM, Michael S. Tsirkin <mst@...hat.com> wrote:
> On Sat, Mar 07, 2015 at 08:06:56PM +0100, Michael S. Tsirkin wrote:
>> virtio spec requires that all drivers set DRIVER_OK
>> before using devices. While rpmsg isn't yet
>> included in the virtio 1 spec, previous spec versions
>> also required this.
>>
>> virtio rpmsg violates this rule: is calls kick
>> before setting DRIVER_OK.
>>
>> The fix isn't trivial since simply calling virtio_device_ready earlier
>> would mean we might get an interrupt in parallel with adding buffers.
>>
>> Instead, split kick out to prepare+notify calls.  prepare before
>> virtio_device_ready - when we know we won't get interrupts. notify right
>> afterwards.
>>
>> Signed-off-by: Michael S. Tsirkin <mst@...hat.com>
>> ---
>
> Ohad, can you review and ack pls?

Sure,

Acked-by: Ohad Ben-Cohen <ohad@...ery.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/