linux-kernel - Re: [PATCH] checkkconfigsymbols.py: make it Git aware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD3Xx4+N=J5Bf6HX2Oe+=vSzWyKrRRpZqtVLjub-H1cCf-9zKQ@mail.gmail.com>
Date:	Wed, 11 Mar 2015 16:04:55 +0100
From:	Valentin Rothberg <valentinrothberg@...il.com>
To:	Paul Bolle <pebolle@...cali.nl>
Cc:	Greg KH <gregkh@...uxfoundation.org>,
	hengelein Stefan <stefan.hengelein@....de>,
	linux-kernel@...r.kernel.org,
	Andreas Ruprecht <rupran@...server.de>
Subject: Re: [PATCH] checkkconfigsymbols.py: make it Git aware

It seems that using 'git cat-file blob commit:path' instead of 'git reset
--hard commit' + open is much more expensive.

The execution time jumps from 3 secs to 3 mins.

Paul, how long does your monster run?  Maybe I just call it wrong or
mess up with caches.

Kind regards,
 Valentin

On Wed, Mar 11, 2015 at 3:33 PM, Valentin Rothberg
<valentinrothberg@...il.com> wrote:
> On Wed, Mar 11, 2015 at 3:19 PM, Valentin Rothberg
> <valentinrothberg@...il.com> wrote:
>> On Wed, Mar 11, 2015 at 1:04 PM, Paul Bolle <pebolle@...cali.nl> wrote:
>>> On Wed, 2015-03-11 at 12:16 +0100, Valentin Rothberg wrote:
>>>> Note that both options require to 'git reset --hard' the user's Git
>>>> tree, which can lead to the loss of uncommitted data.
>>>
>>> My local "800 line perl monster" basically does
>>>     git ls-tree -r $commit_or_tag
>>>
>>> which allows you to generate a list of files and their corresponding
>>> hashes (it also helps with filtering out symlinks by the way).
>>>
>>> The you can do
>>>     git cat-file blob $commit:$path
>>>
>>> or just
>>>     git cat-file blob $hash
>>>
>>> for every file you're interested in and parse the output of that file
>>> (in memory, as it were). None of that messes with the current state of
>>> the tree you're working on.
>>
>> That's a good point.  I used cat-file once in another script but
>> totally forgot its existence, thanks : )  The patch is already queued,
>> so I will change the behavior to your suggestion soon.
>
> Sorry for confusion.  This patch is not queued yet.  The one that
> filters toos/ has been queued : )
>
> Valentin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/