linux-kernel - Re: [PATCH -next] hwmon: fix gpio-fan.c build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54FFA4FB.80007@roeck-us.net>
Date:	Tue, 10 Mar 2015 19:14:19 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Randy Dunlap <rdunlap@...radead.org>,
	LKML <linux-kernel@...r.kernel.org>, lm-sensors@...sensors.org
CC:	Jean Delvare <jdelvare@...e.de>, Simon Guinot <sguinot@...ie.com>
Subject: Re: [PATCH -next] hwmon: fix gpio-fan.c build

On 03/10/2015 04:42 PM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@...radead.org>
>
> Fix build error when CONFIG_THERMAL=m and SENSORS_GPIO_FAN=y
> by preventing that combination.
>
> Fixes these build errors:
>
> drivers/built-in.o: In function `gpio_fan_remove':
> gpio-fan.c:(.text+0x21e97e): undefined reference to `thermal_cooling_device_unregister'
> drivers/built-in.o: In function `gpio_fan_probe':
> gpio-fan.c:(.text+0x21efbc): undefined reference to `thermal_cooling_device_register'
>
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc:	Jean Delvare <jdelvare@...e.de>
> Cc:	Guenter Roeck <linux@...ck-us.net>
> Cc:	lm-sensors@...sensors.org
> Cc:	Simon Guinot <sguinot@...ie.com>
> ---
>   drivers/hwmon/Kconfig |    1 +
>   1 file changed, 1 insertion(+)
>
> --- linux-next-20150310.orig/drivers/hwmon/Kconfig
> +++ linux-next-20150310/drivers/hwmon/Kconfig
> @@ -510,6 +510,7 @@ config SENSORS_G762
>   config SENSORS_GPIO_FAN
>   	tristate "GPIO fan"
>   	depends on GPIOLIB
> +	depends on THERMAL || THERMAL=n
>   	help
>   	  If you say yes here you get support for fans connected to GPIO lines.
>
>
Applied, thanks.

I really have to add that combination to my build tests :-(

Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/