linux-kernel - Re: [PATCH V4 2/2] spmi: pmic_arb: add support for hw version 2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150311130501.241caf24@gavidov-lnx.qualcomm.com>
Date:	Wed, 11 Mar 2015 13:05:01 -0600
From:	Gilad Avidov <gavidov@...eaurora.org>
To:	"Ivan T. Ivanov" <iivanov@...sol.com>
Cc:	sdharia@...eaurora.org, mlocke@...eaurora.org,
	linux-arm-msm@...r.kernel.org, gregkh@...uxfoundation.org,
	linux-kernel@...r.kernel.org, galak@...eaurora.org,
	agross@...eaurora.org
Subject: Re: [PATCH V4 2/2] spmi: pmic_arb: add support for hw version 2

Hi Ivan,

On Tue, 24 Feb 2015 13:01:08 +0200
"Ivan T. Ivanov" <iivanov@...sol.com> wrote:

> 
> Hi Gilad,
> 
> One more comment :-).
> 
> On Thu, 2015-02-19 at 15:54 -0700, Gilad Avidov wrote:
> 
> <snip>
> 
> 
> -static int pmic_arb_wait_for_done(struct spmi_controller *ctrl)
> +static int pmic_arb_wait_for_done(struct spmi_controller *ctrl,
> +                                               void __iomem *base,
> u8 sid, u16 addr) {
>         struct spmi_pmic_arb_dev *dev =
> spmi_controller_get_drvdata(ctrl); u32 status = 0;
>         u32 timeout = PMIC_ARB_TIMEOUT_US;
> -       u32 offset = PMIC_ARB_STATUS(dev->channel);
> +       u32 offset = dev->ver_ops->offset(dev, sid, addr) +
> PMIC_ARB_STATUS;
> 
> 
>         while (timeout--) {
>                 status = pmic_arb_base_read(dev, offset);
> 
> I see that downstream driver is using read or write base address
> based on operation for which we are waiting (read_cmd/write_cmd).
> 
> Should this be reflected here?

Good catch, it should (although it still works fine). 
I'll fix that.

Gilad.

> 
> Ivan.
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/