linux-kernel - Re: [PATCH] netfilter: ipset: fix boolreturn.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 11 Mar 2015 20:21:58 +0100 (CET)
From:	Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>
To:	Pablo Neira Ayuso <pablo@...filter.org>
cc:	kbuild test robot <fengguang.wu@...el.com>, kbuild-all@...org,
	Patrick McHardy <kaber@...sh.net>,
	netfilter-devel@...r.kernel.org, coreteam@...filter.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] netfilter: ipset: fix boolreturn.cocci warnings

On Wed, 11 Mar 2015, Pablo Neira Ayuso wrote:

> Hi Jozsef,
> 
> On Wed, Mar 11, 2015 at 08:08:26PM +0100, Jozsef Kadlecsik wrote:
> > On Wed, 11 Feb 2015, kbuild test robot wrote:
> > 
> > > net/netfilter/xt_set.c:196:9-10: WARNING: return of 0/1 in function 'set_match_v3' with return type bool
> > > net/netfilter/xt_set.c:242:9-10: WARNING: return of 0/1 in function 'set_match_v4' with return type bool
> > > 
> > >  Return statements in functions returning bool should use
> > >  true/false instead of 1/0.
> > > Generated by: scripts/coccinelle/misc/boolreturn.cocci
> > > 
> > > CC: Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>
> > > Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
> > 
> > Patch is applied, thanks.
> 
> I took the liberty to pass this to David already.
> 
> 7f73b9f netfilter: ipset: fix boolreturn.cocci warnings

I acked it actually :-))) - just forgot about it. Sorry for the noise.

Best regards,
Jozsef
-
E-mail  : kadlec@...ckhole.kfki.hu, kadlecsik.jozsef@...ner.mta.hu
PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences
          H-1525 Budapest 114, POB. 49, Hungary
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/