linux-kernel - Re: [PATCH] input: misc: pwm-beeper: remove useless call to pwm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150312214752.GB4720@dtor-ws>
Date:	Thu, 12 Mar 2015 14:47:52 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Olivier Sobrie <olivier@...rie.be>
Cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] input: misc: pwm-beeper: remove useless call to
 pwm_config()

On Thu, Mar 12, 2015 at 02:09:30PM +0100, Olivier Sobrie wrote:
> Calling pwm_config() with a period equal to zero always results in
> error (-EINVAL) and pwm chip config method is never called.
> 
> Signed-off-by: Olivier Sobrie <olivier@...rie.be>

Applied, thank you.

> ---
>  drivers/input/misc/pwm-beeper.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/input/misc/pwm-beeper.c b/drivers/input/misc/pwm-beeper.c
> index a28ee70..2a23643 100644
> --- a/drivers/input/misc/pwm-beeper.c
> +++ b/drivers/input/misc/pwm-beeper.c
> @@ -50,7 +50,6 @@ static int pwm_beeper_event(struct input_dev *input,
>  	}
>  
>  	if (value == 0) {
> -		pwm_config(beeper->pwm, 0, 0);
>  		pwm_disable(beeper->pwm);
>  	} else {
>  		period = HZ_TO_NANOSECONDS(value);
> -- 
> 1.9.1
> 

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/