linux-kernel - Re: [PATCH 1/2] ACPI / EC: Cleanup logging/debugging splitter support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 12 Mar 2015 15:33:09 -0700
From:	Joe Perches <joe@...ches.com>
To:	Lv Zheng <lv.zheng@...el.com>
Cc:	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	Len Brown <len.brown@...el.com>, Lv Zheng <zetalog@...il.com>,
	linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org
Subject: Re: [PATCH 1/2] ACPI / EC: Cleanup logging/debugging splitter
 support.

On Fri, 2015-02-27 at 14:48 +0800, Lv Zheng wrote:
> This patch refines logging/debugging splitter support so that when DEBUG is
> disabled, splitters won't be visible in the kernel logs while they are
> still available for developers when DEBUG is enabled.
> 
> This patch also refines the splitters to mark the following handling
> process boundaries:
>   +++++: boundary of driver starting/stopping
>          boundary of IRQ storming
>   =====: boundary of transaction advancement
>   *****: boundary of EC command
>          boundary of EC query
>   #####: boundary of EC _Qxx evaluation

trivia:

> diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
[]
>  /* --------------------------------------------------------------------------
> + *                           Logging/Debugging
> + * -------------------------------------------------------------------------- */
> +
> +/*
> + * Splitters used by the developers to track the boundary of the EC
> + * handling processes.
> + */

It'd be nice to comment/document these 3 letter descriptions
a bit better here in the source code.

> +#ifdef DEBUG
> +#define EC_DBG_SEP	" "
> +#define EC_DBG_DRV	"+++++"
> +#define EC_DBG_STM	"====="
> +#define EC_DBG_REQ	"*****"
> +#define EC_DBG_EVT	"#####"

Maybe:

#define EC_DBG_SEP	" "
#define EC_DBG_DRV	"+++++"		/* drivers start/stop */
#define EC_DBG_STM	"====="		/* irq storm */
#define EC_DBG_REQ	"*****"		/* ec command boundary */
#define EC_DBG_EVT	"#####"		/* EC _Qxx evaluation */
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/