linux-kernel - Re: [PATCH] kernel:Change the function definiton of do_exit to comply with its function prototypes in kernel.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20150312161636.1e450cca1f4cad34555b751c@linux-foundation.org>
Date:	Thu, 12 Mar 2015 16:16:36 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Nicholas Krause <xerofoify@...il.com>
Cc:	oleg@...hat.com, mhocko@...e.cz, mingo@...nel.org,
	peterz@...radead.org, ionut.m.alexa@...il.com, riel@...hat.com,
	peter@...leysoftware.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kernel:Change the function definiton of do_exit to
 comply with its function prototypes in kernel.h

On Wed, 11 Mar 2015 00:36:50 -0400 Nicholas Krause <xerofoify@...il.com> wrote:

>  This fixes the function definiton of do_exit to comply with its
>  function prototype as  defined in kernel.h as found when running 
>  sparse on the latest updated version of the mainline kernel.
> 
> ...
>
> -void do_exit(long code)
> +void do_exit(long error_code)

We still have

include/linux/module.h:#define module_put_and_exit(code) do_exit(code)

Probably changing the header files is the way to go - error_code is a
bit of a mouthful.

Actually, using "exit_code" everywhere would be best - that's what the
thing does, and it gets copied into task_struct.exit_code.

And change complete_and_exit(code).

do_group_exit() already uses exit_code.

sys_exit_group() uses "error_code".

It's rather a little mess we've made in there!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/