linux-kernel - Re: [PATCH 18/22] usb: gadget: serial: %pF is only for function pointers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150312044532.GB29718@saruman.tx.rr.com>
Date:	Wed, 11 Mar 2015 23:45:32 -0500
From:	Felipe Balbi <balbi@...com>
To:	Scott Wood <scottwood@...escale.com>
CC:	<trivial@...nel.org>, <linux-kernel@...r.kernel.org>,
	<linux-usb@...r.kernel.org>, Felipe Balbi <balbi@...com>
Subject: Re: [PATCH 18/22] usb: gadget: serial: %pF is only for function
 pointers

On Wed, Mar 11, 2015 at 10:13:53PM -0500, Scott Wood wrote:
> Use %pS for actual addresses, otherwise you'll get bad output
> on arches like ppc64 where %pF expects a function descriptor.
> 
> Signed-off-by: Scott Wood <scottwood@...escale.com>
> Cc: linux-usb@...r.kernel.org
> Cc: Felipe Balbi <balbi@...com>
> ---
>  drivers/usb/gadget/function/u_serial.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/function/u_serial.c b/drivers/usb/gadget/function/u_serial.c
> index 491082a..89179ab 100644
> --- a/drivers/usb/gadget/function/u_serial.c
> +++ b/drivers/usb/gadget/function/u_serial.c
> @@ -912,7 +912,7 @@ static int gs_put_char(struct tty_struct *tty, unsigned char ch)
>  	unsigned long	flags;
>  	int		status;
>  
> -	pr_vdebug("gs_put_char: (%d,%p) char=0x%x, called from %pf\n",
> +	pr_vdebug("gs_put_char: (%d,%p) char=0x%x, called from %ps\n",
                                                                 ^
								 S ??

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)