linux-kernel - Re: [PATCH] phy: exynos-mipi-video: Fix unbalanced lock on non-regmap path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <550124FB.2080506@ti.com>
Date:	Thu, 12 Mar 2015 11:02:43 +0530
From:	Kishon Vijay Abraham I <kishon@...com>
To:	Axel Lin <axel.lin@...ics.com>
CC:	Julia Lawall <Julia.Lawall@...6.fr>,
	Sylwester Nawrocki <sylvester.nawrocki@...il.com>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	"linux-samsung-soc@...r.kernel.org" 
	<linux-samsung-soc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] phy: exynos-mipi-video: Fix unbalanced lock on non-regmap
 path



On Wednesday 11 March 2015 05:36 AM, Axel Lin wrote:
> Remove the second lock on non-regmap path.
>
> Fixes: 278270e39efa (phy: exynos-mipi-video: Use spin_lock to protct state->regmap rmw operations)
> Reported-by: Julia Lawall <Julia.Lawall@...6.fr>
> Signed-off-by: Axel Lin <axel.lin@...ics.com>

merged after squashing it with the original patch.

Thanks
Kishon
> ---
>   drivers/phy/phy-exynos-mipi-video.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/phy/phy-exynos-mipi-video.c b/drivers/phy/phy-exynos-mipi-video.c
> index 8d6d117..df7519a 100644
> --- a/drivers/phy/phy-exynos-mipi-video.c
> +++ b/drivers/phy/phy-exynos-mipi-video.c
> @@ -75,7 +75,6 @@ static int __set_phy_state(struct exynos_mipi_video_phy *state,
>   	} else {
>   		addr = state->regs + EXYNOS_MIPI_PHY_CONTROL(id / 2);
>
> -		spin_lock(&state->slock);
>   		val = readl(addr);
>   		if (on)
>   			val |= reset;
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/