linux-kernel - Re: [PATCH v7 11/18] memory: tegra: Add EMC (external memory controller) driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1426147454.5304.9.camel@x220>
Date:	Thu, 12 Mar 2015 09:04:14 +0100
From:	Paul Bolle <pebolle@...cali.nl>
To:	Tomeu Vizoso <tomeu.vizoso@...labora.com>
Cc:	linux-tegra@...r.kernel.org,
	Mikko Perttunen <mikko.perttunen@...si.fi>,
	Mikko Perttunen <mperttunen@...dia.com>,
	Stephen Warren <swarren@...dotorg.org>,
	Thierry Reding <thierry.reding@...il.com>,
	Alexandre Courbot <gnurou@...il.com>,
	Joerg Roedel <jroedel@...e.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 11/18] memory: tegra: Add EMC (external memory
 controller) driver

On Wed, 2015-03-11 at 11:34 +0100, Tomeu Vizoso wrote:
> --- a/drivers/memory/tegra/Kconfig
> +++ b/drivers/memory/tegra/Kconfig
> +
> +

(Nit: just one empty line, please.)

> +config TEGRA124_EMC
> +	bool "Tegra124 External Memory Controller driver"

This patch adds a bool symbol...

> +	default y
> +	depends on TEGRA_MC && ARCH_TEGRA_124_SOC
> +	help
> +	  This driver is for the External Memory Controller (EMC) found on
> +	  Tegra124 chips. The EMC controls the external DRAM on the board.
> +	  This driver is required to change memory timings / clock rate for
> +	  external memory.
> \ No newline at end of file

(Another nit, reported by git.)

> --- a/drivers/memory/tegra/Makefile
> +++ b/drivers/memory/tegra/Makefile
> @@ -5,3 +5,5 @@ tegra-mc-$(CONFIG_ARCH_TEGRA_114_SOC) += tegra114.o
>  tegra-mc-$(CONFIG_ARCH_TEGRA_124_SOC) += tegra124.o
>  
>  obj-$(CONFIG_TEGRA_MC) += tegra-mc.o
> +
> +obj-$(CONFIG_TEGRA124_EMC) += tegra124-emc.o

... and tegra124-emc.o will never be part of a module ...

> --- /dev/null
> +++ b/drivers/memory/tegra/tegra124-emc.c

... so:

> +#include <linux/module.h>

- I guess linux/module.h is not needed;

> +MODULE_DEVICE_TABLE(of, tegra_emc_of_match);

- this macro will be preprocessed away;

> +static int tegra_emc_probe(struct platform_device *pdev)
> +{
> +	[...]
> +
> +	platform_set_drvdata(pdev, tegra);
> +
> +

(Nit: this adds two empty lines.)

> +	return 0;
> +};

> +MODULE_AUTHOR("Mikko Perttunen <mperttunen@...dia.com>");
> +MODULE_DESCRIPTION("Tegra124 EMC memory driver");
> +MODULE_LICENSE("GPL v2");

- and these three macros will be, effectively, preprocessed away,

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/