linux-kernel - RE: [PATCH RFC] f2fs: add fast symlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <000701d05ca3$77a597b0$66f0c710$@samsung.com>
Date:	Thu, 12 Mar 2015 17:02:47 +0800
From:	Chao Yu <chao2.yu@...sung.com>
To:	'Wanpeng Li' <wanpeng.li@...ux.intel.com>
Cc:	'Jaegeuk Kim' <jaegeuk@...nel.org>,
	'Changman Lee' <cm224.lee@...sung.com>,
	linux-f2fs-devel@...ts.sourceforge.net,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: RE: [PATCH RFC] f2fs: add fast symlink

Hi Wanpeng,

> -----Original Message-----
> From: Wanpeng Li [mailto:wanpeng.li@...ux.intel.com]
> Sent: Thursday, March 12, 2015 2:42 PM
> To: Chao Yu
> Cc: 'Wanpeng Li'; 'Jaegeuk Kim'; 'Changman Lee'; linux-f2fs-devel@...ts.sourceforge.net;
> linux-fsdevel@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH RFC] f2fs: add fast symlink
> 
> Hi Chao,
> On Thu, Mar 12, 2015 at 12:17:29PM +0800, Chao Yu wrote:
> >
> >We always remain space in inode page for inline xattr data,
> >so it's better to define our max size of fast symlink as below:
> >
> >#define MAX_FAST_SYMLINK_SIZE	(MAX_INLINE_DATA + 1)
> >
> 
> Thanks for your review, I just handle all your comments and it works
> well.
> 
> Btw, one question, if inline xattr data area is reserved in inode
> even if it isn't mounted w/ inline_xattr option? If yes, why it
> is reserved?

It's not, it keeps space in inode page only if inode is created when
inline_xattr option is set. What I comment and suggest for
MAX_FAST_SYMLINK_SIZE is wrong, sorry about that.

We'd better set max size of fast symlink according to inline_xattr flag:

static inline unsigned int max_fast_symlink_size(struct inode *inode)
{
	return sizeof(__le32) * addrs_per_inode(F2FS_I(inode));
}

How do you think?

Thanks,

> 
> Regards,
> Wanpeng Li

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/