linux-kernel - Re: [PATCH 2/3] dgnc: remove DGNC_VERIFY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150312101325.GA6897@kroah.com>
Date:	Thu, 12 Mar 2015 11:13:25 +0100
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Giedrius Statkevičius 
	<giedrius.statkevicius@...il.com>
Cc:	lidza.louina@...il.com, markh@...pro.net,
	driverdev-devel@...uxdriverproject.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] dgnc: remove DGNC_VERIFY_BOARD macro

On Tue, Mar 10, 2015 at 09:29:19PM +0200, Giedrius Statkevičius wrote:
> In sysfs methods struct device is guaranteed to not be NULL thus bd will
> not be NULL in any way. Also, checking for bd->magic != DGNC_BOARD_MAGIC
> and bd->state != BOARD_READY is redundant because we already don't
> initialize broken boards since "dgnc: Don't save boards in memory that
> have failed to initialize" and make sysfs files after initializing the
> board in dgnc_driver.c or IOW they are already set for successfully
> initialized boards before their sysfs files created (412 and 593 lines
> in dgnc_driver.c).

As I didn't take your previous patch that this relies on, I can't take
this one at this point in time, sorry.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/