linux-kernel - Re: [RESEND PATCH] hwrng: omap - remove #ifdefery around PM methods

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150312102014.GB18614@gondor.apana.org.au>
Date:	Thu, 12 Mar 2015 21:20:14 +1100
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	Deepak Saxena <dsaxena@...xity.net>, linux-crypto@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH] hwrng: omap - remove #ifdefery around PM methods

On Wed, Mar 11, 2015 at 02:08:36PM -0700, Dmitry Torokhov wrote:
> Instead of using #ifdefs let's mark suspend and resume methods as
> __maybe_unused which will suppress compiler warnings about them being
> unused and provide better compile coverage.
> 
> Because SIMPLE_DEV_PM_OPS() produces an empty omap_rng_pm structure in
> case of !CONFIG_PM_SLEEP neither omap_rng_suspend nor omap_rng_resume
> will end up being referenced and the change will not result in
> increasing image size.
> 
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>

Applied.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/