[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87zj7isd0d.fsf@vitty.brq.redhat.com>
Date: Thu, 12 Mar 2015 11:53:22 +0100
From: Vitaly Kuznetsov <vkuznets@...hat.com>
To: Olaf Hering <olaf@...fle.de>
Cc: "K. Y. Srinivasan" <kys@...rosoft.com>, gregkh@...uxfoundation.org,
linux-kernel@...r.kernel.org, devel@...uxdriverproject.org,
apw@...onical.com
Subject: Re: [PATCH 2/6] Drivers: hv: hv_balloon: keep locks balanced on add_memory() failure
Olaf Hering <olaf@...fle.de> writes:
> On Wed, Mar 11, K. Y. Srinivasan wrote:
>
>> +++ b/drivers/hv/hv_balloon.c
>> @@ -652,6 +652,7 @@ static void hv_mem_hot_add(unsigned long start, unsigned long size,
>> }
>> has->ha_end_pfn -= HA_CHUNK;
>> has->covered_end_pfn -= processed_pfn;
>> + mutex_lock(&dm_device.ha_region_mutex);
>> break;
>> }
>
> Should it call the wrapper instead of doing mutex_lock directly?
> Like 'acquire_region_mutex(false);'.
My "Drivers: hv: hv_balloon: eliminate the trylock path in
acquire/release_region_mutex" (b05d8d9ef5ef21d1b18440430f950304836e1aaa
in char-misc-next) removed these wrappers.
>
> Olaf
--
Vitaly
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists