linux-kernel - Re: nios2: is the ptrace ABI correct?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150312110722.GB894@distanz.ch>
Date:	Thu, 12 Mar 2015 12:07:22 +0100
From:	Tobias Klauser <tklauser@...tanz.ch>
To:	Chung-Lin Tang <chunglin.tang@...il.com>
Cc:	Chung-Lin Tang <cltang@...esourcery.com>,
	Ezequiel Garcia <ezequiel@...guardiasur.com.ar>,
	Arnd Bergmann <arnd@...db.de>, Ley Foon Tan <lftan@...era.com>,
	Walter Goossens <waltergoossens@...e.nl>,
	linux-arch@...r.kernel.org,
	"nios2-dev@...ts.rocketboards.org" <nios2-dev@...ts.rocketboards.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: nios2: is the ptrace ABI correct?

On 2015-03-09 at 18:02:17 +0100, Chung-Lin Tang <chunglin.tang@...il.com> wrote:
> On 2015/3/10 12:54 AM, Chung-Lin Tang wrote:
> > It appears that some of the ways nios2 has organized the
> > ucontext/pt_regs/etc. are remnants of the pre-generic code, some
> > basically because the port was based off m68k.
> > 
> > I've re-organized the headers a bit: nios2/include/asm/ucontext.h is
> > deleted, and re-definition of struct sigcontext now allows use of
> > uapi/asm-generic/ucontext.h directly.  Note that the reorg, despite
> > effectively renaming some fields, is still binary compatible. I'll
> > probably update the corresponding glibc definitions later.
> > 
> > struct pt_regs is now not exported, and all exported register sets are
> > now supposed to follow the 49 register set defined as in GDB now.
> > 
> > Tobias, Ley Foon, how do you think this looks?
> 
> Sorry, accidentally attached unrelated GCC patch instead, this one's the
> correct one.

Sorry for jumping into the discussion so late. The patch looks fine to
me as well. Only one minor nit below. Since Ley Foon already applied it
as is, I'll just send a followup patch.

Thanks Ezequiel, Chung-Lin and Ley Foon for pushing this! Looking
forward to have strace support on nios2.

[...]
> diff --git a/arch/nios2/include/uapi/asm/Kbuild b/arch/nios2/include/uapi/asm/Kbuild
> index 4f07ca3f8..37613119 100644
> --- a/arch/nios2/include/uapi/asm/Kbuild
> +++ b/arch/nios2/include/uapi/asm/Kbuild
> @@ -2,3 +2,5 @@ include include/uapi/asm-generic/Kbuild.asm
>  
>  header-y += elf.h
>  header-y += ucontext.h

This should no longer be needed now that the non-generic ucontext.h is
gone.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/