linux-kernel - Re: [PATCH 2/6] Drivers: hv: hv_balloon: keep locks balanced on add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150312114101.GB10964@mwanda>
Date:	Thu, 12 Mar 2015 14:41:01 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Olaf Hering <olaf@...fle.de>
Cc:	Vitaly Kuznetsov <vkuznets@...hat.com>, apw@...onical.com,
	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
	devel@...uxdriverproject.org
Subject: Re: [PATCH 2/6] Drivers: hv: hv_balloon: keep locks balanced on
 add_memory() failure

On Thu, Mar 12, 2015 at 12:14:28PM +0100, Olaf Hering wrote:
> On Thu, Mar 12, Vitaly Kuznetsov wrote:
> 
> > My "Drivers: hv: hv_balloon: eliminate the trylock path in
> > acquire/release_region_mutex" (b05d8d9ef5ef21d1b18440430f950304836e1aaa
> > in char-misc-next) removed these wrappers.
> 
> I see now. There are many changes in char-misc-next. The description
> gives the impression that mainline is broken. Not sure if thats true,
> perhaps its just char-misc-next which is affected.

Mainline is broken.  We only found these when we removed the wrapper and
then static checkers were able to catch the bug.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/