linux-kernel - Re: [PATCH] ARM: dts: remove usb2-phy on Exynos5 series SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFp+6iHr5pDge7AGfus4uXoe6Oe_Q44B6nzEJYA1==Vb-8PdYA@mail.gmail.com>
Date:	Thu, 12 Mar 2015 18:29:10 +0530
From:	Vivek Gautam <gautamvivek1987@...il.com>
To:	Jaewon Kim <jaewon02.kim@...sung.com>
Cc:	Kamil Debski <k.debski@...sung.com>, Kukjin Kim <kgene@...nel.org>,
	Kishon Vijay Abraham I <kishon@...com>,
	Vivek Gautam <gautam.vivek@...sung.com>,
	Felipe Balbi <balbi@...com>, Inki Dae <inki.dae@...sung.com>,
	Chanwoo Choi <cw00.choi@...sung.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-samsung-soc@...r.kernel.org" 
	<linux-samsung-soc@...r.kernel.org>,
	Linux USB Mailing List <linux-usb@...r.kernel.org>
Subject: Re: [PATCH] ARM: dts: remove usb2-phy on Exynos5 series SoC

Hi,


On Thu, Mar 12, 2015 at 3:40 PM, Jaewon Kim <jaewon02.kim@...sung.com> wrote:
> Exynos5 series SoC does not have usb2-phy on USB3.0 Controller.
> It is controlled by only usb3-phy. So, this patch remove usb2-phy
> property.

Why would you want to remove the usb2-phy property ?
The usb2-phy projected here is actually the UTMI+ phy which is present
as a part of a hybrid PHY controller (that includes both UTMI+ as well
as PIPE3 phys).

And the exynos5-usbdrd phy driver also differentiates between the two PHYs.
It does try to separate out the initializations for UTMI+ and PIPE3
phy, if you notice
the functions:
exynos5_usbdrd_utmi_init() and exynos5_usbdrd_pipe3_init().

I don't think this change seems valid.

>
> Signed-off-by: Jaewon Kim <jaewon02.kim@...sung.com>
> ---
>  arch/arm/boot/dts/exynos5250.dtsi |    4 ++--
>  arch/arm/boot/dts/exynos5420.dtsi |    8 ++++----
>  2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> index 9bb1b0b..b58b169 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -565,8 +565,8 @@
>                         compatible = "synopsys,dwc3";
>                         reg = <0x12000000 0x10000>;
>                         interrupts = <0 72 0>;
> -                       phys = <&usbdrd_phy 0>, <&usbdrd_phy 1>;
> -                       phy-names = "usb2-phy", "usb3-phy";
> +                       phys = <&usbdrd_phy 0>;
> +                       phy-names = "usb3-phy";
>                 };
>         };
>
> diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
> index 9dc2e97..0df14bb 100644
> --- a/arch/arm/boot/dts/exynos5420.dtsi
> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> @@ -845,8 +845,8 @@
>                         compatible = "snps,dwc3";
>                         reg = <0x12000000 0x10000>;
>                         interrupts = <0 72 0>;
> -                       phys = <&usbdrd_phy0 0>, <&usbdrd_phy0 1>;
> -                       phy-names = "usb2-phy", "usb3-phy";
> +                       phys = <&usbdrd_phy0 0>;
> +                       phy-names = "usb3-phy";
>                 };
>         };
>
> @@ -871,8 +871,8 @@
>                         compatible = "snps,dwc3";
>                         reg = <0x12400000 0x10000>;
>                         interrupts = <0 73 0>;
> -                       phys = <&usbdrd_phy1 0>, <&usbdrd_phy1 1>;
> -                       phy-names = "usb2-phy", "usb3-phy";
> +                       phys = <&usbdrd_phy1 1>;
> +                       phy-names = "usb3-phy";
>                 };
>         };
>
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Best Regards
Vivek Gautam
Samsung R&D Institute, Bangalore
India
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/