linux-kernel - Re: [PATCH v2] ARM: l2c: Fix prefetch settings dt parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150312145712.GT8656@n2100.arm.linux.org.uk>
Date:	Thu, 12 Mar 2015 14:57:13 +0000
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Fabrice GASNIER <fabrice.gasnier@...com>
Cc:	Tony Lindgren <tony@...mide.com>,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>,
	Tomasz Figa <t.figa@...sung.com>,
	Arnd Bergmann <arnd@...db.de>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	tomasz.figa@...il.com
Subject: Re: [PATCH v2] ARM: l2c: Fix prefetch settings dt parsing

On Tue, Mar 10, 2015 at 09:59:01AM +0100, Fabrice GASNIER wrote:
> Allow prefetch settings overriding by device tree, in case
> l2x0_cache_size_of_parse() returns value, prefetch tuning
> properties are silently ignored. E.g. arm,double-linefill* and
> arm,prefetch*.
> This happens for example, when "cache-size" or "cache-sets"
> properties haven't been filled in l2c dt node.
> 
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@...com>
> Reviewed-by: Tomasz Figa <tomasz.figa@...il.com>

Patch is okay, but I think the commit message needs to be better :)

"Allow device tree to override the L2C prefetch settings, even when
l2x0_cache_size_of_parse() fails to parse the cache geometry due to (eg)
missing "cache-size" or "cache-sets" properties."

I think with something along those lines, the patch can be put in my
patch system for when I next get around to applying some kernel patches
instead of reading email. :)

Thanks.

-- 
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/