| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1426178426.30327.117.camel@freescale.com> Date: Thu, 12 Mar 2015 11:40:26 -0500 From: Scott Wood <scottwood@...escale.com> To: Fabio Estevam <festevam@...il.com> CC: <trivial@...nel.org>, linux-kernel <linux-kernel@...r.kernel.org>, "USB list" <linux-usb@...r.kernel.org>, Felipe Balbi <balbi@...com> Subject: Re: [PATCH 18/22] usb: gadget: serial: %pF is only for function pointers On Thu, 2015-03-12 at 12:51 -0300, Fabio Estevam wrote: > On Thu, Mar 12, 2015 at 12:13 AM, Scott Wood <scottwood@...escale.com> wrote: > > Use %pS for actual addresses, otherwise you'll get bad output > > on arches like ppc64 where %pF expects a function descriptor. > > From Documentation/printk-formats.txt: > > "On ia64, ppc64 and parisc64 architectures function pointers are > actually function descriptors which must first be resolved. The 'F' and > 'f' specifiers perform this resolution and then provide the same > functionality as the 'S' and 's' specifiers." > > ,so current code should work fine on ppc64, right? No. __builtin_return_address() returns a pointer to an instruction, not a function pointer descriptor. If you use %pF on the former, it'll print instruction opcodes as if they were the address. -Scott -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists