linux-kernel - Re: [PATCH] net:Kconfig: drop no sense dependence entry for BONDING

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1426181444.11398.167.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Thu, 12 Mar 2015 10:30:44 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Martin Walch <walch.martin@....de>
Cc:	Wang YanQing <udknight@...il.com>, davem@...emloft.net,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-kbuild@...r.kernel.org, j.vosburgh@...il.com,
	vfalico@...il.com, gospo@...ulusnetworks.com,
	Erik Hugne <erik.hugne@...csson.com>
Subject: Re: [PATCH] net:Kconfig: drop no sense dependence entry for BONDING

On Thu, 2015-03-12 at 16:14 +0100, Martin Walch wrote:
> On Thursday 12 March 2015 21:59:33 Wang YanQing wrote:
> > "IPV6 || IPV6=n" means no dependence!
> 
> IPV6 and BONDING are both tristate symbols and therefore this is not the same
> as no dependency. When setting IPV6 to m, the expression evaluates to
> 
> "IPV6 || IPV6=n" 
> "m || m=n"
> "m || n"
> "m"
> 
> So, if IPV6=m, then BONDING can only be n or m, but not y.

Right.

But it looks like bonding driver no longer has IPV6 dependencies.

Patch should work, but the changelog should be changed to explain why
the patch is valid, and this should be tested.

Presumably we need to make sure the following builds and runs properly

CONFIG_BONDING=y
CONFIG_IPV6=m



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/