linux-kernel - Re: [PATCH 3/6] dgnc: convert TRUE/FALSE #defines to 1/0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5501E68D.6010802@gmail.com>
Date:	Thu, 12 Mar 2015 21:18:37 +0200
From:	Giedrius Statkevičius 
	<giedrius.statkevicius@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
CC:	lidza.louina@...il.com, markh@...pro.net,
	devel@...verdev.osuosl.org, gregkh@...uxfoundation.org,
	driverdev-devel@...uxdriverproject.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/6] dgnc: convert TRUE/FALSE #defines to 1/0

On 2015.03.12 20:59, Dan Carpenter wrote:
> On Thu, Mar 12, 2015 at 08:14:25PM +0200, Giedrius Statkevičius wrote:
>> TRUE/FALSE defined in dgnc_types.h are only used in dgnc_tty.c thus it
>> would be better to just use 1/0 to avoid unnecessary extra files and
>> includes.
>>
> 
> Use true/false.  I don't care much about this personally but true/false
> is kernel style these days.
> 
> regards,
> dan carpenter
> 

After researching more this whole dgnc_Major_Serial_Registered and
dgnc_Major_TransparentPrint_Registered seem pretty pointless because
they only get set to true or false depending on if those boards are
initialised or not and we won't initialise them two or more times -
dgnc_init_one() is a probe method and it's never called anywhere else.
This seems like a way better solution - redundant stuff will be removed
from the struct and a unnecessary header will be removed (types.h is for
bools) :) I'll fix this up in v2 but now I'll wait for more comments on
other patches (if there will be any) for a bit.

-- 
Thanks,
Giedrius
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/