linux-kernel - Re: [PATCH] fs, omfs: add NULL terminator in the end up the token list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150312202408.GF9840@localhost>
Date:	Thu, 12 Mar 2015 16:24:08 -0400
From:	Bob Copeland <me@...copeland.com>
To:	Sasha Levin <sasha.levin@...cle.com>
Cc:	linux-kernel@...r.kernel.org,
	"open list:OMFS FILESYSTEM" <linux-karma-devel@...ts.sourceforge.net>
Subject: Re: [PATCH] fs, omfs: add NULL terminator in the end up the token
 list

On Thu, Mar 12, 2015 at 04:11:09PM -0400, Sasha Levin wrote:
> match_token() expects a NULL terminator at the end of the token list so that
> it would know where to stop. Not having one causes it to overrun to invalid
> memory.
> 
> In practice, passing a mount option that omfs didn't recognize would sometimes
> panic the system.

Yikes, thanks for the catch!

Acked-by: Bob Copeland <me@...copeland.com>

> Signed-off-by: Sasha Levin <sasha.levin@...cle.com>

-- 
Bob Copeland %% http://bobcopeland.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/