linux-kernel - Re: [PATCH v3 1/6] staging: rtl8192e: fix coding style issues (merge broken strings)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1426206426.9314.4.camel@perches.com>
Date:	Thu, 12 Mar 2015 17:27:06 -0700
From:	Joe Perches <joe@...ches.com>
To:	Mateusz Kulikowski <mateusz.kulikowski@...il.com>
Cc:	gregkh@...uxfoundation.org, mdcasey@...bloom.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/6] staging: rtl8192e: fix coding style issues
 (merge broken strings)

On Fri, 2015-03-13 at 00:53 +0100, Mateusz Kulikowski wrote:
[]
> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c b/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c
> index 0e6bdd2..01d2201 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c
> @@ -47,8 +47,8 @@ void PHY_SetRF8256Bandwidth(struct net_device *dev,
>  						0x0e, bMask12Bits, 0x021);
>  
>  			} else {
> -				RT_TRACE(COMP_ERR, "PHY_SetRF8256Bandwidth(): "
> -					 "unknown hardware version\n");
> +				RT_TRACE(COMP_ERR,
> +					 "PHY_SetRF8256Bandwidth(): unknown hardware version\n");

Another thing you might consider is to change these
embedded function names in another patch to use
	"%s: ", __func__

				RT_TRACE(COMP_ERR,
					 "%s: "unknown hardware version\n",
					 __func__)

There's a cocci script for that.
http://cocci.systeme.lip6.narkive.com/nKXf6Bmy/finding-embedded-function-names



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/