linux-kernel - Re: [PATCH] staging: sm750fb: braces, indents, spaces fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Fri, 13 Mar 2015 11:24:29 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Ragavendra BN <ragavendra.bn@...il.com>
Cc:	gregkh@...uxfoundation.org, linux-fbdev@...r.kernel.org,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: sm750fb: braces, indents, spaces fix

On Thu, Mar 12, 2015 at 10:14:36PM -0700, Ragavendra BN wrote:
> This patch removes the braces for the single line if statement. It fixes
> the indent positions correctly. It fixes the spaces appropriately making the code give no
> warnings by the checpath.pl script check.

your From: is still having [user] in your email address.
and you are doing too many things in a single patch. one patch should
do only one type of change.

> 
> 
> Signed-off-by: Ragavendra BN <ragavendra.bn@...il.com>
> 
this extra blank line is not necessary here.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/