linux-kernel - Re: [PATCHv2 7/7] zram: deprecate zram attrs sysfs nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150313081625.GA410@swordfish>
Date:	Fri, 13 Mar 2015 17:16:25 +0900
From:	Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
To:	Minchan Kim <minchan@...nel.org>
Cc:	Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>,
	Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Nitin Gupta <ngupta@...are.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCHv2 7/7] zram: deprecate zram attrs sysfs nodes

On (03/13/15 16:39), Minchan Kim wrote:
> AFAIK, kernel rule doesn't prefer multi-line for printk string
> because it makes hard to work with grep. Anyway, it's trivial.
> For example, checkpatch will emit
> 
> WARNING: quoted string split across lines
> 

yes, exactly. that's why I mentioned it in the first place.


well... something like this (a bit ugly, but can do the trick):

pr_warn_once("%d (%s): Attribute %s (and others) will be removed. %s\n"
                       task_pid_nr(current),
                       current->comm,
                       name,
                       "See zram documentation.");

will resend the patch later today.

> Anyway, I agree with your way.

thanks for review!

	-ss
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/